isset() narrows string-key in int-keyed-array to numeric-string
#3472
Conversation
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
| ); | ||
| } | ||
|
|
||
| $narrowedKey = AllowedArrayKeysTypes::narrowOffsetKeyType($varType, $dimType); |
There was a problem hiding this comment.
as a first step I think its easier to have a static method for this.
after we get more similar with the array_key_exists impl we will see whether it makes sense to move this method into the ConstantScalarType-interface, as we discussed in dresden
| assertType('int', $i); | ||
| } else { | ||
| assertType('int', $i); | ||
| } | ||
| assertType('int', $i); | ||
|
|
||
| if (isset($arr[$s])) { | ||
| if (isset($intKeyedArr[$s])) { | ||
| assertType('numeric-string', $s); |
There was a problem hiding this comment.
this assertion is the interessting one, which got more precise with this PR
|
-> it seems to be caused by some github infrastructure thing -> works again |
staabm
force-pushed
the
isset-precise
branch
from
afcd618 to
532858f
Compare
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
isset-precise
branch
4 times, most recently
from
5a57c75 to
fde07b5
Compare
staabm
force-pushed
the
isset-precise
branch
from
fde07b5 to
2f2e842
Compare
|
Thank you! |
initial steps to make
isset()implementation even more similar toarray_key_existsso we can in the end hopefully share the implementationcommit 1: plain 1:1 refactoring, no implementation changes
commit 2: the fix as the PR topic suggests